feat: integration test for single phase polyhedral discretizations #3780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarDuran
added
type: testing
OmarDuran
requested review from
CusiniM,
castelletto1,
jhuang2601,
paveltomin and
rasimHZ
as code owners
…difference-single-phase
…difference-single-phase
paveltomin
removed
ci: run CUDA builds
Updated baseline entry for PR #3780 with a link to the integrated tests.
…difference-single-phase
OmarDuran
added
the
ci: run code coverage
OmarDuran
added
ci: run CUDA builds
castelletto1
reviewed
Oct 2, 2025
src/coreComponents/integrationTests/fluidFlowTests/polyhedral_voronoi_complex.vtk
Outdated
Show resolved
Hide resolved
castelletto1
reviewed
Oct 2, 2025
inputFiles/singlePhaseFlow/polyhedralDiscretizations/incompressible_consistency_mfd.xml
Outdated
Show resolved
Hide resolved
castelletto1
reviewed
Oct 2, 2025
inputFiles/singlePhaseFlow/polyhedralDiscretizations/incompressible_consistency_tpfa.xml
Outdated
Show resolved
Hide resolved
paveltomin
deleted the
feat-integration-test-for-mimetic-finite-difference-single-phase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces integration tests for single-phase flow on polyhedral meshes, verifying TPFA and MFD discretizations against exact pressure solutions on star-shaped meshes.
Test Coverage:
TPFA Integration Tests: Parameterized on three mesh types (polyhedral_voronoi_complex.vtk, polyhedral_voronoi_lattice.vtk, polyhedral_voronoi_regular.vtk) to ensure machine-precision solutions on regular meshes and highlight TPFA inconsistency on non–k-orthogonal meshes.
MFD Integration Tests: Parameterized for multiple inner product types (TPFA, QuasiTPFA, QuasiRT, Simple, BdVLM), verifying exact pressure solutions on star-shaped meshes.
TPFA vs MFD Consistency Tests: Cross-check that MFD with innerProductType="TPFA" reproduces the same pressure field as the standard TPFA solver on all meshes.
On the Meshes
Voronoi mesh constructed from a 2d lattice
This mesh Includes n-facet polygonal prisms with 4 to 6 facets (n in {4,5,6}).
Voronoi mesh constructed from a cloud of points
This mesh is designed to cover all element types supported by GEOS and include local mesh adaptations. This mesh Includes n-facet polygonal prisms with 3 to 11 facets (n in {3,4,5,6,7,8,9,10,11}).
Regular k-ortogonal mesh